added tests for Authorization
Gitea Actions Demo / Explore-Gitea-Actions (pull_request) Has been cancelled Details

This commit is contained in:
Alie 2023-12-27 20:33:25 +01:00
parent ec4f9eb2c3
commit ada964c493
4 changed files with 132 additions and 65 deletions

View File

@ -38,8 +38,6 @@ class AuthControler {
if (err) { if (err) {
return res.status(403).json("Invalid token provided"); return res.status(403).json("Invalid token provided");
} }
console.log("Authorization provided for ", next.name, " to app ", app);
next(); next();
}); });
} else { } else {

View File

@ -14,7 +14,7 @@ app.get("/", (_, res) => {
}); });
app.get("/images", imageController.getAllImages); app.get("/images", imageController.getAllImages);
app.post("/images", imageController.addImage); app.post("/images", authControler.authorize, imageController.addImage);
app.post("/login", authControler.login) app.post("/login", authControler.login)
// Set the default port to 8080, or use the PORT environment variable // Set the default port to 8080, or use the PORT environment variable

View File

@ -1,88 +1,135 @@
import { afterEach, describe, expect, it, mock } from "bun:test"; import { afterEach, beforeAll, describe, expect, it, mock } from "bun:test";
import request from "supertest"; import request from "supertest";
import { app } from "../src"; import { app } from "../src";
import imageService from "../src/services/ImageService"; import imageService from "../src/services/ImageService";
const imageServiceOriginal = imageService; const imageServiceOriginal = imageService;
const tok = await request(app)
.post("/login")
.send({ app: "tester", secret: "test" });
const token = tok.body.token;
afterEach(() => { afterEach(() => {
mock.restore(); mock.restore();
mock.module("../src/services/ImageService", () => ({ default: imageServiceOriginal })); mock.module("../src/services/ImageService", () => ({
}) default: imageServiceOriginal,
}));
});
describe("GET / shows all of the endpoints", async () => { describe("GET / shows all of the endpoints", async () => {
const res = await request(app).get("/"); const res = await request(app).get("/");
it("should be", async () => { it("should be", async () => {
expect(res.body).toHaveProperty("endpoints"); expect(res.body).toHaveProperty("endpoints");
}); });
it("should be an array", () => { it("should be an array", () => {
expect(Array.isArray(res.body.endpoints)).toBeTrue(); expect(Array.isArray(res.body.endpoints)).toBeTrue();
}) });
}) });
describe("GET /images works properly", async () => { describe("GET /images works properly", async () => {
const res = await request(app).get("/images"); const res = await request(app).get("/images");
it("should be an array", () => { it("should be an array", () => {
expect(Array.isArray(res.body.images)).toBeTrue(); expect(Array.isArray(res.body.images)).toBeTrue();
}); });
it("should return a 200", async () => { it("should return a 200", async () => {
expect(res.statusCode).toBe(200); expect(res.statusCode).toBe(200);
}); });
}); });
describe("POST /images works properly", () => { describe("POST /images works properly", () => {
it("should return 201 for new image", async () => {
const res = await request(app).post("/images").send({ it("should return 401 for unauthenticated requests", async () => {
url: "https://test.url.com/1", const res = await request(app)
.post("/images")
.send({
url: "https://test.url.com/0",
status: "available", status: "available",
tags: ["2girls", "touhou"] tags: ["2girls", "touhou"],
}); });
expect(res.status).toSatisfy(status => [201].includes(status)); expect(res.status).toBe(401);
}); });
it("should return 409 for a repeated images", async () => { it("should return 403 for invalid tokens", async () => {
await request(app).post("/images").send({ const res = await request(app)
url: "https://test.url.com/2", .post("/images")
.set("authorization", `Bearer token`)
.send({
url: "https://test.url.com/0",
status: "available", status: "available",
tags: ["2girls", "touhou"] tags: ["2girls", "touhou"],
}); });
expect(res.status).toBe(403);
});
const res = await request(app).post("/images").send({ it("should return 201 for new image", async () => {
url: "https://test.url.com/2", const res = await request(app)
status: "available", .post("/images")
tags: ["2girls", "touhou"] .set("authorization", `Bearer ${token}`)
}); .send({
url: "https://test.url.com/1",
status: "available",
tags: ["2girls", "touhou"],
});
expect(res.status).toBe(201);
});
expect(res.status).toBe(409); it("should return 409 for a repeated images", async () => {
}); await request(app)
.post("/images")
.set("authorization", `Bearer ${token}`)
.send({
url: "https://test.url.com/2",
status: "available",
tags: ["2girls", "touhou"],
});
it("should return 500 for an error on the service", async () => { const res = await request(app)
mock.module("../src/services/ImageService", () => ({ .post("/images")
default: { .set("authorization", `Bearer ${token}`)
add: () => { throw new Error("This is an expected testing error"); } .send({
} url: "https://test.url.com/2",
})); status: "available",
tags: ["2girls", "touhou"],
});
const res = await request(app).post("/images").send({ expect(res.status).toBe(409);
url: "https://test.url.com/3", });
status: "available",
tags: ["2girls", "touhou"]
});
expect(res.status).toBe(500); it("should return 500 for an error on the service", async () => {
}); mock.module("../src/services/ImageService", () => ({
default: {
add: () => {
throw new Error("This is an expected testing error");
},
},
}));
it("should return 400 for malformed requests", async () => { const res = await request(app)
mock.restore(); .post("/images")
const res = await request(app).post("/images").send({ .set("authorization", `Bearer ${token}`)
url: "https://test.url.com/4", .send({
status: "wrong", url: "https://test.url.com/3",
tags: ["2girls", "touhou"] status: "available",
}); tags: ["2girls", "touhou"],
expect(res.status).toBe(400); });
});
expect(res.status).toBe(500);
});
it("should return 400 for malformed requests", async () => {
mock.restore();
const res = await request(app)
.post("/images")
.set("authorization", `Bearer ${token}`)
.send({
url: "https://test.url.com/4",
status: "wrong",
tags: ["2girls", "touhou"],
});
expect(res.status).toBe(400);
});
}); });

22
tests/auth.test.ts Normal file
View File

@ -0,0 +1,22 @@
import { describe, expect, it, mock } from "bun:test";
import request from "supertest";
import { app } from "../src";
describe("/login", async () => {
const correctRespose = await request(app).post("/login").send({
app: "tester",
secret: "test",
});
it("should return 200 for correct login", () => {
expect(correctRespose.status).toBe(200);
});
it("should contain a token", () => {
expect(correctRespose.body).toHaveProperty("token");
});
it("should return 403 for invalid credentials", async () => {
const res = await request(app).post("/login").send({});
expect(res.status).toBe(403);
});
});